Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[V1] Improve AsyncLLM and API Server #11237

Closed
wants to merge 135 commits into from
Closed

[V1] Improve AsyncLLM and API Server #11237

wants to merge 135 commits into from

Conversation

robertgshaw2-neuralmagic
Copy link
Collaborator

@robertgshaw2-neuralmagic robertgshaw2-neuralmagic commented Dec 16, 2024 •
edited by github-actions bot
Loading

NOTE: I am in process of slipping this PR into separate pieces

SUMMARY:

  • Improve API server performance by making add_request_id middleware optional
  • Improve AsyncLLM performance with 3 process architecture and reduction of task switching in AsyncLLM
  • Better error handling with SIGQUIT
  • Reduce usage of zmq sockets by switching readiness probes to use mp.Pipe
  • Avoid footguns with ulimit
  • Added abstractions for background process handling

TODO:

  • Re-enable profiling
  • Make AsyncLLM shutdown cleaner (raises an error in the stack trace)
  • More testing

@github-actions GitHub Actions
Copy link

👋 Hi! Thank you for contributing to the vLLM project.
Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can do one of these:

  • Add ready label to the PR
  • Enable auto-merge.

🚀

@mergify mergify bot added the frontend label Dec 16, 2024
@robertgshaw2-neuralmagic robertgshaw2-neuralmagic changed the title workign e2e [V1] API Server Performance Dec 16, 2024
@robertgshaw2-neuralmagic
fixup
cbc043e 
git
@mergify Mergify
Copy link

mergify bot commented Dec 23, 2024

This pull request has merge conflicts that must be resolved before it can be
merged. Please rebase the PR, @robertgshaw2-neuralmagic.

https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/working-with-forks/syncing-a-fork

@mergify mergify bot added the needs-rebase label Dec 23, 2024
mgoin
mgoin reviewed Dec 24, 2024
View reviewed changes
vllm/v1/engine/async_llm.py Outdated Show resolved Hide resolved
vllm/v1/engine/async_llm.py Outdated Show resolved Hide resolved
vllm/v1/engine/async_llm.py
Comment on lines +296 to +301
for out in outputs:
# Note: it is possible that a request was aborted
# due to client cancellation while EngineCoreOutputs
# are still flowing, so we just ignore.
if out.request_id in self.rid_to_queue:
self.rid_to_queue[out.request_id].put_nowait(out)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you think this isn't worth logging since we are sure the request was aborted?

vllm/v1/engine/core.py Show resolved Hide resolved
vllm/v1/utils.py Outdated Show resolved Hide resolved
vllm/v1/utils.py Outdated Show resolved Hide resolved
@mergify mergify bot removed the needs-rebase label Dec 24, 2024
rickyyx
rickyyx reviewed Dec 26, 2024
View reviewed changes
Copy link
Contributor

@rickyyx rickyyx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With the http middleware issue fixed - curious how much perf diff the new 3 process architecture yields?

@mergify Mergify
Copy link

mergify bot commented Dec 26, 2024

This pull request has merge conflicts that must be resolved before it can be
merged. Please rebase the PR, @robertgshaw2-neuralmagic.

https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/working-with-forks/syncing-a-fork

@mergify mergify bot added the needs-rebase label Dec 26, 2024
This was referenced Dec 26, 2024
Merged
Merged
Merged
Merged
Merged
Closed
@robertgshaw2-neuralmagic
Copy link
Collaborator Author

Closing as complete

@robertgshaw2-neuralmagic robertgshaw2-neuralmagic deleted the remove-async-stream branch December 31, 2024 15:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rickyyx rickyyx rickyyx left review comments

@mgoin mgoin mgoin left review comments

@WoosukKwon WoosukKwon Awaiting requested review from WoosukKwon WoosukKwon is a code owner

@njhill njhill Awaiting requested review from njhill njhill is a code owner

@ywang96 ywang96 Awaiting requested review from ywang96 ywang96 is a code owner

@comaniac comaniac Awaiting requested review from comaniac comaniac is a code owner

@alexm-neuralmagic alexm-neuralmagic Awaiting requested review from alexm-neuralmagic alexm-neuralmagic is a code owner

Assignees
No one assigned
Labels
frontend needs-rebase
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@robertgshaw2-neuralmagic @mgoin @rickyyx